TA Feedback (milestone 2): Code

UBC-MDS / dsci-522_group-28

This is the repository for DSCI 522 Group 28

MIT License

0 stars 6 forks source link

TA Feedback (milestone 2): Code #45

Closed jbourak closed 3 years ago

jbourak commented 3 years ago

I left the model_tuning.py script to run for ~15 mins (longer than the sum of the fit times in table 2) but it did not seem to complete in this time (I eventually stopped it manually). You may want to add a warning indicating that running this script will take a while.

Also, there are some unnecessary imports in eda_ms2.py

debanandasarkar commented 3 years ago

Hi Jordan,

Thanks for the feedback. We have added runtime warning about classifier_evaluation.py and model_tuning.py in Makefile and README.

We will remove the unused imports in eda_ms2.py soon.

Cheers, Debananda