search

UBC-MDS / dsci522-group16

This is the repo for the group project for DSCI 522 (group 16)
MIT License
0 stars 7 forks source link

Peer Feedback - Sukhdeep #41

Closed sukh2929 closed 3 years ago

sukh2929 commented 3 years ago

Hi All,

I really appreciate the hard work you all have done here. I really like how everything is arranged and documented carefully.  Here are some pointers which I think can help to improve the project.

Documentation:

  1. Overall, it was very clear but it would be great if the second paragraph in the “about” section can be split into two paragraphs for more readability.
  2. Also, I think in Readme, you could add a line stating which features you considered or dropped for analysis.

Code:

  1. All scripts have proper comments and are readable.

Analysis and reasoning:

  1. I think the analysis is quite clear and succinct.

Communication:

  1. One small observation is that in the report: the recall value and accuracy score in the chart are not the same as shown in the summary and analysis above the confusion matrix.
  2. The code link in the report does not direct to the root folder. It should be directed to the doc folder.
  3. There are 2 eda files in the folder. You could remove the eda file which is not needed anymore.

Suggestions: already stated above.

Thank you!