Hi classmates, great effort on the project and neat selection of data! The project is very well done.
Here's my feedback:
Documentation: Functions and code are very well-documented with comments throughout.
Code: Easily readable and reproducible.
Analysis and reasoning: Overall clear and sufficient analysis. Great flow of reasoning.
Communication: I found some tiny typos in your report under Analysis. The words "initial" and "conjunction" are misspelt. I would also suggest making the size of the table "Cross-validation results for different classifiers" smaller. The improvements section is a great addition to your report!
Suggestions:
I would consider moving figures generated by running make all to results subfolder called figures, essentially splitting results into figures and a subfolder called predictions. I would also suggest keeping only one EDA file in src directory. I noticed the link referring to literal document in the README file does not link to the report in doc folder.
Hi classmates, great effort on the project and neat selection of data! The project is very well done.
Here's my feedback:
Documentation: Functions and code are very well-documented with comments throughout.
Code: Easily readable and reproducible.
Analysis and reasoning: Overall clear and sufficient analysis. Great flow of reasoning.
Communication: I found some tiny typos in your report under Analysis. The words "initial" and "conjunction" are misspelt.
I would also suggest making the size of the table "Cross-validation results for different classifiers" smaller.
The improvements section is a great addition to your report!
Suggestions: I would consider moving figures generated by running make all to results subfolder called
figures
, essentially splitting results intofigures
and a subfolder calledpredictions
.I would also suggest keeping only one EDA file in src directory.
I noticed the link referring to
literal document
in the README file does not link to the report in doc folder.