search

UBC-MDS / f1-2021-analysis

A dashboard summarizing the Formula 1 2021 season results and highlights
https://eric1208.shinyapps.io/f1-2021-analysis/
MIT License
0 stars 4 forks source link

Implement slider functionality to modify points plot #36

Closed erictsai1208 closed 1 year ago

erictsai1208 commented 1 year ago

Implements #29 and #35

erictsai1208 commented 1 year ago

There's a lot of repeated code since the same race table is being added to both the driver and team tab. However, it only works this way because each slider has its own ID, and apparently two different IDs cannot be used to change one thing (or I just wasn't able to figure out how). For now though, everything seems to be working well. We can figure out how to deal with the repetition later when we have more time.

tanmayag97 commented 1 year ago

@erictsai1208 everything is showing in panel 1, is that supposed to be correct?

erictsai1208 commented 1 year ago

No I'm still debugging this issue...

erictsai1208 commented 1 year ago

@erictsai1208 everything is coming in panel 1, is that supposed to be correct?

Should be resolved now. Please check.

tanmayag97 commented 1 year ago

Looks good, approving