search

UBC-MDS / feature-selection-python

A Python package for feature selection with ML estimators
MIT License
5 stars 1 forks source link

Revert "Fix test for n_features_to_select" #83

Closed vcuspinera closed 4 years ago

vcuspinera commented 4 years ago

Following conversation on GitHub with Ryan, that I shouldn't have merge it, I am reverting this PR

codecov[bot] commented 4 years ago

Codecov Report

Merging #83 into master will decrease coverage by 0.32%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #83      +/-   ##
===========================================
- Coverage   100.00%   99.67%   -0.33%     
===========================================
  Files            9        9              
  Lines          315      312       -3     
===========================================
- Hits           315      311       -4     
- Misses           0        1       +1
Flag Coverage Δ
#unittests 99.67% <50.00%> (-0.33%) :arrow_down:
Impacted Files Coverage Δ
feature_selection/recursive_feature_elimination.py 96.42% <0.00%> (-3.58%) :arrow_down:
tests/test_recursive_fetaure_elimination.py 100.00% <ø> (ø)
feature_selection/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64af71c...5c2fb7a. Read the comment docs.

techrah commented 4 years ago

Created in error. Will just ignore and close.