search

UBC-MDS / feature-selection-python

A Python package for feature selection with ML estimators
MIT License
5 stars 1 forks source link

Add comments to variance thresholding #94

Closed jackyho112 closed 4 years ago

jackyho112 commented 4 years ago

Related to https://github.com/UBC-MDS/software-review/issues/36#issuecomment-601878044

codecov[bot] commented 4 years ago

Codecov Report

Merging #94 into master will not change coverage by %. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          319       319           
=========================================
  Hits           319       319
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
feature_selection/variance_thresholding.py 100.00% <ø> (ø)
feature_selection/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ecb117...1d8938a. Read the comment docs.

techrah commented 4 years ago

The changes are fine. Not sure what happened with the build. Can you run the build again?

jackyho112 commented 4 years ago

@ryanhomer rerunning