UBC-MDS / fifa-potential

Supervised machine learning model to predict potential rating of players in FIFA 22
https://ubc-mds.github.io/fifa-potential/high-potential-fifa-prediction-report.html
Other
0 stars 0 forks source link

Docker Container Requirements #12

Closed srfrew closed 10 months ago

srfrew commented 10 months ago

Discussion for docker containers! To be linked to various pull requests.

Current plan:

srfrew commented 10 months ago

Dockerfile is developed! Would folks be able to test the build?

docker build --tag fifa_potential:latest .
docker run --rm -it -p 8888:8888 fifa_potential:latest

Once this is merged I'll implement the workflows within main and move to docker compose

srfrew commented 10 months ago

Next step! GitHub Actions deployment

srfrew commented 10 months ago

GitHub Actions completed, a test workflow as created and it will run on every change to Dockerfile

On to Docker Compose

srfrew commented 10 months ago

Docker compose completed. Next steps (eventually) would be to update the readme

meretelutz commented 10 months ago

I can update the Readme!

meretelutz commented 10 months ago

Updated!

WaleedMahmood1 commented 10 months ago

If it's finalized, should I accept the pull request for the addition of the docker instructions in the README?