Modularizing the Visualizations for EDA

UBC-MDS / fifa-potential

Supervised machine learning model to predict potential rating of players in FIFA 22

https://ubc-mds.github.io/fifa-potential/high-potential-fifa-prediction-report.html

Other

0 stars 0 forks source link

Modularizing the Visualizations for EDA #20

Closed WaleedMahmood1 closed 7 months ago

WaleedMahmood1 commented 7 months ago

This branch will have the code and tests for the modularized function for the visualizations of the EDA part of the project.

meretelutz commented 7 months ago

Just ran your tests and everything looks great! One thing though - I don't think you should include the .ipynb files in the src and tests folder in the repo. I did the same thing and tested everything using a notebook, but I think the final version needs to be just the scripts. I'll remove them from the repo and recommit, but if you want to hold on to them, make sure you make a copy before you pull again!