Adding in the modularized functions into the analysis file

UBC-MDS / fifa-potential

Supervised machine learning model to predict potential rating of players in FIFA 22

https://ubc-mds.github.io/fifa-potential/high-potential-fifa-prediction-report.html

Other

0 stars 0 forks source link

Adding in the modularized functions into the analysis file #24

Closed WaleedMahmood1 closed 10 months ago

meretelutz commented 10 months ago

The plot_numeric_distributions function had a similar issue to Jake's in that it assumed the list of numeric features had elements that were numeric data type when really they're just strings

WaleedMahmood1 commented 10 months ago

Oh you are completely right! I missed it, thanks for fixing it! I should have made it so to check that those specific columns in the data are of numeric type.

meretelutz commented 10 months ago

Everything is working on my machine! I haven't deleted any of the stuff you commented out yet. I'll do that and re-run just to double check.

meretelutz commented 10 months ago

Ready to merge, I think!