UBC-MDS / fifa-potential

Supervised machine learning model to predict potential rating of players in FIFA 22
https://ubc-mds.github.io/fifa-potential/high-potential-fifa-prediction-report.html
Other
0 stars 0 forks source link

Week 3 To-Dos #28

Closed meretelutz closed 7 months ago

meretelutz commented 7 months ago
  1. Abstract more code from your literate code document (.ipynb, .Rmd, or .qmd) to scripts (e.g., .R or .py) Steps to make scripts for:

    • [x] 01_load_clean_tidy
    • [x] 02_eda_figures
    • [x] 03_preprocessing
    • [x] 04_model_selection
    • [x] 05_hyperparameter_scoring
  2. Edit your literate code document (.ipynb, Qmd or *.Rmd) so that it’s sole job is to narrate your analysis, display your analysis artifacts (i.e., figures and tables), and nicely format the report

  3. Write bash script to run all scripts (baby makefile)

  4. Update your project’s computational environment as you add dependencies to your project

  5. Submit

jbarns14 commented 7 months ago

Step 1 - making the scripts done

srfrew commented 7 months ago

I was reading the requirements for Milestone 3 and I think we need to export our final model into the results folder!

meretelutz commented 7 months ago

Do you mean the model object itself? Does it say that explicitly in the instructions? I think we were hoping to avoid having to do that and deal with pickles

srfrew commented 7 months ago

I noticed that Tiff's had them.

Overall, I've completed docstrings, black formatting, bash script pipeline, and small readme tweaks in the bash-makefile branch #35

I think things are ready for review and merge!

srfrew commented 7 months ago

Submitted! The notebook was updated, github pages configured, and readme updated with new links and to-dos

meretelutz commented 7 months ago

Closing this issue as we submitted Milestone 3