search

UBC-MDS / fifa-potential

Supervised machine learning model to predict potential rating of players in FIFA 22
https://ubc-mds.github.io/fifa-potential/high-potential-fifa-prediction-report.html
Other
0 stars 0 forks source link

Scripts folder #47

Closed srfrew closed 7 months ago

srfrew commented 7 months ago

Moving core scripts to script folder, and making sure nothing breaks

meretelutz commented 7 months ago

Was testing out this branch and running into problems with running pytest. Not sure if its just an issue on my end? Its running but taking forever and seems to have stalled out while running the tests for test_file_download.py

meretelutz commented 7 months ago

OK it finally finished running. 3 tests are failing now, trying to fix them now.

meretelutz commented 7 months ago

Tried fixing it but was getting even more errors. Maybe @srfrew can fix it? These are the errors I'm getting when I run pytest

FAILED tests/test_file_download.py::test_csv_in_zip - NameError: Input `url` is not a valid URL
FAILED tests/test_file_download.py::test_csv_valid - NameError: Input `url` is not a valid URL
FAILED tests/test_file_download.py::test_cleanup - FileNotFoundError: [Errno 2] No such file or directory: 'data/raw/this_is_a...
meretelutz commented 7 months ago

Ok nevermind I think something was up with my computer because now everything is working fine. Sorry! Merging now.