UBC-MDS / nameforme

NameForMe - A python package to help suggest baby names.
MIT License
3 stars 3 forks source link

Milestone 2 Feedback #59

Closed Glenn032787 closed 1 year ago

Glenn032787 commented 1 year ago

Congratulations on finishing milestone 2! We can see you put a lot of work into this project, nice work!

You done everything in the rubric and gotten full marks! Good Job!

Some generate feedback I have for the project (unrelated to the requirements for the course/milestone) is to include a utility function to download the database locally. Your functions are set up to download the file every time it is being run which takes a long time so I would suggest having a function to download the data and have the function accept that as an input. When running the tests, it took quite a while to run as it downloads and deletes the data from memory for every function.