search

UBC-MDS / nameforme

NameForMe - A python package to help suggest baby names.
MIT License
3 stars 3 forks source link

Milestone 3 Feeback #92

Closed andytai7 closed 1 year ago

andytai7 commented 1 year ago

Congratulations on finishing milestone 3 group 3! Nice work uploading your package to PYPI! Nice work on the Tests on R and setting up your R repo! 
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.

R package

Screenshot 2023-01-30 at 3 10 26 PM

Python package

Greatjob! CICD is good, and Uploaded to PYPI

Great job, you’re at the final stretch. One milestone left :)

eyrexh commented 1 year ago

Hi Andy @andytai7,

I tested our group R package last week with zero errors and warnings. Also, I tried to test it again this night after seeing your feedback and got no error at all. Can you please show me the detailed error message? Thank you.

Screenshot 2023-01-30 at 22 21 28 Screenshot 2023-01-30 at 22 21 40 Screenshot 2023-01-30 at 22 00 01
andytai7 commented 1 year ago

It looks like i pulled the Rstudio package yesterday when maybe some of the team members were playing around with the tests causing them to fail? That's my only reasonable explanation.

As you can see below, all the tests pass, when i pull from the milestone repo. This was my mistake, therefore all the grades will be rewarded back. Good luck in milestone 4!

![Uploading Screenshot 2023-01-31 at 2.30.13 PM.png…]()

eyrexh commented 1 year ago

No worries. Thank you for the explanation!