UBC-MDS / noaastn

Python package that downloads, processes and visualizes weather data from the NOAA website.
https://noaastn.readthedocs.io/en/latest/
MIT License
3 stars 3 forks source link

Update stations info test #39

Closed chiragrank closed 3 years ago

chiragrank commented 3 years ago

Changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (7c83f0c) into main (ca2079c) will increase coverage by 0.70%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   95.88%   96.59%   +0.70%     
==========================================
  Files           5        5              
  Lines         170      176       +6     
==========================================
+ Hits          163      170       +7     
+ Misses          7        6       -1     
Flag Coverage Δ
unittests 96.59% <100.00%> (+0.70%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
noaastn/noaastn.py 94.17% <100.00%> (+0.05%) :arrow_up:
tests/test_get_stations_info.py 100.00% <100.00%> (+4.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca2079c...7c83f0c. Read the comment docs.

chiragrank commented 3 years ago

@spentelow . You are right the linter seemed unhappy at those places. Running the linter locally, there were some more errors that seemed to be showing at my end. I fixed that and had already pushed the changes before looking at your message here. Hope that is okay