Closed spentelow closed 3 years ago
Merging #47 (e8cdb07) into main (4533f35) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 176 176
=========================================
Hits 176 176
Flag | Coverage Δ | |
---|---|---|
unittests | 100.00% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_get_weather_data.py | 100.00% <ø> (ø) |
|
noaastn/__init__.py | 100.00% <100.00%> (ø) |
|
noaastn/noaastn.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1f622d5...e8cdb07. Read the comment docs.
Addressed various changes from Marco and Chad's reviews:
Marco:
get_weather_data()
fxn to allow station numbers that begin with a letterChad:
station_number
argument ofget_weather_data()
function in the usage section of the readmeget_weather_data()
function against the output table fromget_stations_info()
is a good one, it has not been implemented. To implement it would mean callingget_stations_info()
from within theget_weather_data()
function and I think that the loss in performance is not worth the gain in being able to explicitly check the user input. The revised error raised by the function if an year is entered for which there is no data is shown below and, while not ideal, is descriptive enough at this stage.