search

UBC-MDS / noaastnr

An r package that downloads, processes, and visualizes weather data from the NOAA website
https://ubc-mds.github.io/noaastnr/
Other
0 stars 1 forks source link

Update documentation and other minor changes #29

Closed chiragrank closed 3 years ago

chiragrank commented 3 years ago

Changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #29 (a9cc3b0) into main (2ba3274) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a9cc3b0 differs from pull request most recent head 0f24281. Consider uploading reports for the commit 0f24281 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          198       198           
=========================================
  Hits           198       198

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2223a8b...0f24281. Read the comment docs.

chenzhao2020 commented 3 years ago

We I run the check on local windows, there is a warning 'qpdf' is needed for checks on size reduction of PDFs. Do we need to add qpdf to the dependencies in DESCRIPTION file?

chenzhao2020 commented 3 years ago

It seems like a local problem. There is no warning shows in the github action history. Besides, there is no pdf file generated during the process. Will merge it.