search

UBC-MDS / olympic_medal_htest

MIT License
0 stars 10 forks source link

Add script 04_htest and Rmd 04_htest #17

Closed ming0701 closed 2 years ago

ming0701 commented 2 years ago

You can run the following on the command line if you execute from the root of the repo: Rscript src/04_htest.R --data="data/olympics_cleaned.csv" --saving_path="results"

The script will create png and rds files in the saving_path.

Currently the .Rmd file is set to knit an HTML file

stevenleung2018 commented 2 years ago

Thanks for the work.

  1. There is apparently a typo in line 42 of the 04_htest.Rmd file. The line now looks like this:

The code used to perform the analysis and create this report can be found here: https://github.com/UBC-MDS/olympic_medal_htest

I think it should at least look like this:

The code used to perform the analysis and create this report can be found here: https://github.com/UBC-MDS/olympic_medal_htest

And I also suspect that the URL should be changed to point to the repo instead of the 03_EDA.Rmd file.

  1. Re: Line 59, it is correct to say, "We fail to reject the null hypothesis," but strictly speaking we cannot conclude that they are equal. There is a difference between "fail to reject" and "accept". The subtle difference is that we now fail to prove that they are not equal, but strictly speaking we have not proved that they are equal.

Anyway, since #1 is minor and #2 is something open for discussion, I will approve the pull request.

ming0701 commented 2 years ago

Thanks for the comment. I will change #1 tomorrow morning. For #2, yes, I think I will change the conclusion to "there is no statistically significant that the proportion of athletes younger than 25 that win a medal is greater than the proportion of athletes of age 25 or older that win a medal". Please let me know if you have other suggestion.