UBC-MDS / predicting_wine_quality

MIT License
0 stars 5 forks source link

Milestone 2 feedback #44

Open andytai7 opened 2 years ago

andytai7 commented 2 years ago

Dear group 13,

You guys have made improvements! Great job! Below highlight some feedback for milestone 2. In addition, things under Suggestions: should be taken as suggestions and do not affect your mark.

Expectations: Mechanics

Comments Only Son Chau and Nikita Shymberg had committed to the repo.

Project organization and documentation expectations: Writing

Comments "For the purpose of regression model and evaluation of the relevant features, we are using the following algorithms to perform this task:"

Grammar errors

"Besides, we have a couple of signs about some variables. "

Besides what?

Project organization and documentation expectations: Reasoning C Comments "regression models" Bayes and SVM are both classification models, not regression models.

"We are using (Pedregosa et al. 2011), (Van Rossum and Drake 2009), (team 2020), (Xie, n.d.), (Harris et al. 2020) and (Virtanen et al. 2020), (Römer and Kraska 2007), (Sievert 2018) and (Joblib Development Team 2020)." These are not packages but are intext citations. Please fix.

You said your group uses six models, but you only used KNN.

For evaluation you gave "r2_score mse_score rmae_score mae_score mse_log_score mae_log_score." This group only utilizes r2_score and defines none of these scores, making it very confusing. Would you mind explaining all these metrics.

"it is reasonable that KNN gives us superior “predictions.”" This is really confusing, why is it reasonable to the layperson?

Suggestion:

"we do not have a balanced database" Would you please justify how you are or aren't dealing with this?

If you weigh numerical values and see how similar they are, maybe use a heat map?

Overall great job!