Review feedback from Holly Williams

zoepan00 commented 4 years ago

[x] displays the image for imgfilter, redusize, reducolor. same as issue #74 (first 3)
[x] It might be helpful to have a description of the function arguments and options in the README. I understand that the information is also available in the readthedocs documentation, so it is up to you whether you think it is overkill to have it duplicated.
[x] redusize I was a little bit surprised by the output of this function. From the description, I was expecting it to output something similar to the results we had in the DSCI 512 seam carving lab, but it seems to just crop the bottom right corner of the image to the desired size. If this is the intended use, then maybe the documentation and descriptions could be updated?
[x] reducolor I noticed you have two style options (0 = black and white, and 1 = 8 colors). Is it possible to allow the user to select the number of colours? This might be too much work and out of scope for the 524 timeline. PR #76
- Thank you for your suggestions. The reason why I didn't include more colors is due to the color reduction algorithm is based on 3 color channels, and so the reduced number of colors would be n^3. And for colors more than 10, the color reduction effect is not very obvious.
- I'm going to include more color options based on your and other reviewers' suggestions.
[ ] you could consider adding a citation information section in your README.md to let others know how you would like to be cited if they use your package.

dataubc commented 4 years ago

The Readme is now updated to reflect what the user should expect form redusize function

dataubc commented 4 years ago

Redusize now displays the image

dataubc commented 4 years ago

tests reflects these changes

UBC-MDS / pyimager