Peer Review Feedback

[slbsolomon]

The following is the triage of what will be addressed based on Serg's Feedback:

Will address

• In the README, ensure that intrinio-sdk is installed before rintrinio
• simplify intrinio-sdk install
• fix gather_financial_statement_company_compare() issue
• Error handling consistency - use stop() everywhere
• add link to docs in README

Will address time permitting (lower priority)

• gather_financial_statement_time_series() produces an warning on runs
• change gather_financial_statement_time_series() and gather_financial_statement_company_compare() column names to the things we are comparing
• change gather_financial_statement_time_series() and gather_financial_statement_company_compare() to return data as characters rather than factors

Will not address at this time

• return comparison data as a pivoted df rather than a long df
• add frequency argument to functions
• will not add API key to the README
• gather_stock_time_series() function throws the wrong error when an invalid ticker is put in - allowed values are different depending on if there is a free API key or paid one

[sirine-chahma]

I think all those issues are relevant!

[sirine-chahma]

for this issue fix gather_financial_statement_company_compare() issue is it about the example?

[slbsolomon]

Yes it is about the example

[slbsolomon]

Notes:

• In the README, ensure that intrinio-sdk is installed before rintrinio - added note under "dependencies" to install intrinio-sdk first
• simplify intrinio-sdk install - done
• fix gather_financial_statement_company_compare() issue - Sirine had already fixed, verified that it is working
• Error handling consistency - use stop() everywhere - done
• add link to docs in README - done

[slbsolomon]

Attempted to rename columns in gather_financial_statement_time_series and gather_financial_statement_company_compare but was unable to due to dplyr issue