UBC-MDS / rintrinio

R package that draws needed data from intrinio API objects
https://ubc-mds.github.io/rintrinio/
Other
0 stars 3 forks source link

Peer review feedbacks #73

Closed sirine-chahma closed 4 years ago

sirine-chahma commented 4 years ago

Feedbacks from Carlina :

To do :

To do if we have time :

sirine-chahma commented 4 years ago

For this point : Have a list with the definition of some tickers (AAPL, CSCO,...) I don't think it is not necessary as the people who will use our package and know Intrinio will already know what those tickers mean.

sirine-chahma commented 4 years ago

For this point : Add test to check if the API is a string and return a meaningful message if not I tried to adress it, but I have the feeling it is not possible because as soon as I try to use the api key without quotation marks, it throws an error because this object doesn't exist. I think the error that is thrown has a message that is meaningful enough : object api_key not found . Moreover, we specified in the docstrings of our functions that the api_key must be a character.