UBC-MDS / seismophobia

MIT License
0 stars 5 forks source link

Milestone 2 General Feedback #68

Closed ahofmann4 closed 3 years ago

ahofmann4 commented 3 years ago

Hello Seisomophobia Group!

Overall very well done! Your code runs smoothly, and is well written. We have just a few minor suggestions for your group.

Summarized comments from Tiff, Analise, Jordan, and Eric are below.

Feedback on the Report: 1) figure labels are too small to read 2) pull back on claims of the model because model is very close to random 3) looking at the data as proportions would be a more useful way to look at it

Code Feedback: 2) tests missing in functions 3)script main function needs to go to top of scripts so code purpose can be better understood