search

UBC-MDS / snapedautility

https://snapedautility.readthedocs.io/
MIT License
0 stars 1 forks source link

Write test cases and code for function detect_outliers #17

Closed harryyikhchan closed 2 years ago

harryyikhchan commented 2 years ago

Finished the function detect_outliers Added three test case in test_detect_outliers

AraiYuno commented 2 years ago

image Hey @harryyikhchan. I see some warnings in your unit test. It shouldn't be a problem since it's just a warning, but just heads up.

harryyikhchan commented 2 years ago

Got it, fixing it now

AraiYuno commented 2 years ago

image Here is one suggestion.

You have written one test case for each input type. Simply adding a couple of cases for each unit test function would be wonderful!

harryyikhchan commented 2 years ago

Thanks for the suggestion! will be included in the upcoming PR