UBC-MDS / software-review-2021

1 stars 1 forks source link

Submission: remoodji (R) #12

Open YikiSu opened 3 years ago

YikiSu commented 3 years ago

Submitting Authors:

Repository: remoodji Version submitted: 0.3.0 Editor: Tiffany Timbers (@ttimbers) Reviewers: TBD

Archive: TBD Version accepted: TBD


Package Description:

Remoodji is a text analysis package that focuses on sentiment analysis in text files in quantitative and qualitative ways. Specifically, it is used for determining what kind of underlying emotion your input text gives off and quantitative analyses of your text (character, word, and sentence count as well as visual and quantitative sentiment analysis). The emotions analyzed include angry, sad, happy, and disgust. Another core feature of Remoodji is it replaces words with emojis to provide the user with a text file where it is easier to pick up on the emotions being conveyed in a visually appealing snapshot view. This package can be useful when proofreading an important message which you want to elicit a certain emotion or tone, particularly with a given pattern or rhythm (speeches, letters, applications, songs, poems, etc).

Scope

Technical checks

Confirm each of the following by checking the box.

This package:

Publication options

MEE Options - [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)

Code of conduct

jkim222383 commented 3 years ago

This is a super neat package, I love it!

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

Documentation

The package includes all the following forms of documentation:

For packages co-submitting to JOSS

The package contains a paper.md matching JOSS's requirements with:

  • [ ] A short summary describing the high-level functionality of the software
  • [ ] Authors: A list of authors with their affiliations
  • [ ] A statement of need clearly stating problems the software is designed to solve and its target audience.
  • [ ] References: with DOIs for all those that have one (e.g. papers, datasets, software).

Functionality

Estimated hours spent reviewing: 2


Review Comments

Installation

devtools::load_all() resulted in

Error: Dependency package(s) 'tidytext','textdata','emojifont' not available.

This only required a relatively simple fix by manually installing these packages. This issue may be partially addressed by adding these dependencies under Depends section of DESCRIPTION.

Function Documentation

Codes for the functions are written in a very readable manner using tidyverse-style.

All examples were reproducible and ran smoothly locally. It may help to include function call examples in the roxygen documentation as well (This was already done for counter function).

Most external function calls were made using explicit NAMESPACE::FUNCTION calls, but there were a few examples where this was not explicit (e.g. geom_bar, ggtitle).

Contribution Guidelines

Very detailed and clearly-written contribution guidelines in the CONTRIBUTING file

Functionality / Performance / Automated Tests

Has the functionalities as described in the vignettes, passes all tests.

Can increase the test coverage:

General Comments

Disclaimer: I am not a lawyer and my understanding of software licenses may be flawed

While it's great to see that this package is licensed under the MIT License, there may be license compatibility issues because some of the package dependencies are not as permissive as MIT license. As an example, base R and tidyverse are licensed under GPL-3. While GPL-3 and MIT licenses are compatible, the resulting work should be distributed under GPL-3.


I'm super excited you got this to work fairly well. Good work Team remoodji!