UBC-MDS / software-review-2021

1 stars 1 forks source link

Submission: sptidy (R) #13

Open anodaini opened 3 years ago

anodaini commented 3 years ago

Submitting Author: Jacob McFarlane @JacobMcFarlane, Asma Al-Odaini (@anodaini), Xudong Yang @xudongyang2, Heidi Ye @heidi-ye Repository: sptidy Version submitted: 0.2.0 Editor: TBD Reviewers: TBD

Archive: TBD Version accepted: TBD


Package: sptidy
Title: Tidy-up linear regression and kmeans model outputs
Version: 0.0.0.9000
Authors@R: 
    c(person(given = "Jacob",
           family = "McFarlane",
           role = c("aut", "cre"),
           email = "jacob@jakenow.net"),
    person(given = "Asma",
           family = "Al-Odaini",
           role = c("aut")),
    person(given = "Peter",
           family = "Yang",
           role = c("aut")),
    person(given = "Heidi",
           family = "Ye",
           role = c("aut"))
           )
Description: Sptidy implements a tidy and augment function for base R’s linear regression and Tidymodel’s kmeans clustering to ease model selection and assessment tasks. This package is a simplified reimplementation of the existing tidy and augments functions in the Broom package. Sptidy’s family of tidy functions returns a dataframe that summarizes important model information, while the augment function expands the original dataframe to include additional model specific information by observation. This package is meant to complement Sktidy, a Python package that was created to tidy up the scikit-learn package.
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
Suggests: 
    testthat (>= 3.0.0),
    covr
Config/testthat/edition: 3
URL: https://github.com/UBC-MDS/sptidy
BugReports: https://github.com/UBC-MDS/sptidy/issues
Imports: 
    tibble,
    dplyr,
    broom

Scope

Technical checks

Confirm each of the following by checking the box.

This package:

Publication options

MEE Options - [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)

Code of conduct

larahabashy commented 3 years ago

Package Review

Please check off boxes as applicable, and elaborate in the comments below. Your review is not limited to these topics, as described in the reviewer guide

Documentation

The package includes all the following forms of documentation:

Functionality

Estimated hours spent reviewing: 2.5


Review Comments

Hi team! Great job on this package, it provides a really good simplification of model summary outputs. I really liked how you kept your documentation consistent and clear. I just had a few small comments and suggestions on the package, but overall, I think you all did an amazing job!

README

Code of Conduct