Open yuanxiongbear opened 3 years ago
Please check off boxes as applicable, and elaborate in the comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).For packages co-submitting to JOSS
- [ ] The package has an obvious research application according to JOSS's definition
The package contains a
paper.md
matching JOSS's requirements with:
- [ ] A short summary describing the high-level functionality of the software
- [ ] Authors: A list of authors with their affiliations
- [ ] A statement of need clearly stating problems the software is designed to solve and its target audience.
- [ ] References: with DOIs for all those that have one (e.g. papers, datasets, software).
Estimated hours spent reviewing: ~1 hour
Great work overall! Appreciate the effort all of you have been put into the development of this package. Here're some places that I think can be improved:
get_tweets()
function does not give users options to input Twitter API credentials directly as function parameters. This could sometimes be inconvenient as package users might not always have access to the base operating system (think about the Kaggle notebook we have used in our neural network course). Therefore, you should consider adding the optional parameter(s) that allow users to input the credential via code directly.tweetr.R
contains some testing code for development. Although they have been commented out, you should still consider removing them from your source code. If you believe this is something useful for demonstration, you can put it in your documentation instead.LICENSE
and LICENSE.md
. The file LICENSE
only contains the names of the authors and without any license text. This has confused GitHub and make it unable to infer your license and label it on the top page (I believe this is an issue in the original cookie-cutter template). You should consider merging the content of these 2 files all into LICENSE
.twitteR
used in your package, and then make the mock object return some deterministic and simple data to check against. In that way, you will be able to test your function without actually fetching dynamic data from Twitter. One mock package you can consider using is: https://cran.r-project.org/web/packages/mockery/vignettes/mocks-and-testthat.htmlAgain, good work everyone. Thank @mmyz88 for letting me know the way to run the package.
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).For packages co-submitting to JOSS
- [ ] The package has an obvious research application according to JOSS's definition
The package contains a
paper.md
matching JOSS's requirements with:
- [ ] A short summary describing the high-level functionality of the software
- [ ] Authors: A list of authors with their affiliations
- [ ] A statement of need clearly stating problems the software is designed to solve and its target audience.
- [ ] References: with DOIs for all those that have one (e.g. papers, datasets, software).
Estimated hours spent reviewing: 1 hour
Hi Team,
Thanks for building this package tweetr
! I enjoy playing around with this package and it surely performs meaningful text analysis and sentiment analysis on tweets.
While I was using it, I remarked a few things down as follows, and hope it could help to enhance the overall user experience more.
plot_hashtags
counts hashtag words and gets the top 15 frequent words. It would be more flexible and reasonable without the hardcode as 15
. Instead, you might put the number of frequent words as an argument in this function for future adjustment. For instance, users might be interested in the top 30 frequent words hence it is always better without any hardcode. plot_timeline
since the count of tweets cannot respond to complete information of the timeline analysis. Some tweets include more sentences while others might not. I am wondering whether it would be better to count the words of all the tweets posted at a certain time range instead of counting the tweets only. visualize_sentiments
, again, I would suggest adding an argument N
with a default value of 10 to retrieve the top N positive and negative results, leading to a more flexible function without any hard code. Your current function can only obtain the top 10 results from the data frame of sentiment analysis, which is quite limited.
name: tweetr about: Use this template to submit software for review
Submitting Author: Yuan Xiong (@yuanxiongbear) Other Authors: Huanhuan Li (@huan-ds), Yuanzhe(Marco) Ma (@mmyz88), Jared Splinter (@JaredSplinter) Repository: https://github.com/UBC-MDS/tweetr.git Version submitted: v0.2.0 Editor: Tiffany Timbers(@ttimbers) Reviewers: TBD
Archive: TBD Version accepted: TBD
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
Who is the target audience and what are scientific applications of this package?
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category?
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
[ ] Do you intend for this package to go on CRAN?
[ ] Do you intend for this package to go on Bioconductor?
[ ] Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
- [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)Code of conduct