Open ssyayayy opened 3 years ago
Hello! This is a great package and is easy to use. I believe it covers an audience that would really benefit from such a tool. Below is my review.
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).For packages co-submitting to JOSS
- [ ] The package has an obvious research application according to JOSS's definition
The package contains a
paper.md
matching JOSS's requirements with:
- [ ] A short summary describing the high-level functionality of the software
- [ ] Authors: A list of authors with their affiliations
- [ ] A statement of need clearly stating problems the software is designed to solve and its target audience.
- [ ] References: with DOIs for all those that have one (e.g. papers, datasets, software).
check()
, see reviewer notes belowEstimated hours spent reviewing: 1.25 hours
The package is well documented and well-organized. The audience is well-considered as the package output's simplicity fits well with the audience who would like simple visualization and summary outputs.
Additional commentary:
For the function corpora_compare
and corpora_best_match
, it would be helpful to note in the function documentation (and in the examples provided in the README), that it will download a pre-trained model if there isn't one available, as it does take a considerable amount of time (20 minutes). One option would be for the user to confirm that they would like to download the large file.
For the function corpora_compare
, there is an optional argument metric
that is used for the calculation of distance, but it doesn't seem like there are other possible options to be chosen. Perhaps this should not be an argument since if a user were to enter anything other than the default, it would not work. If there are other options for metrics, they should be noted in the documentation. Further examining the functions, it looks as though "euclidean" is an option, but is missing from the documentation.
For the function corpora_best_match
, the number of times the model is loaded is related to how many words you are comparing. It would be more efficient to only load the model once regardless of the number of comparisons, in case a user provided a large number of words for comparison. Example provided below:
> corpora_best_match('flower',c('television','candy','plant'))
Downloaded model found. Loading downloaded model...
Downloaded model found. Loading downloaded model...
Downloaded model found. Loading downloaded model...
# A tibble: 3 x 2
corpora metric
<chr> <dbl>
1 candy 0.818
2 plant 0.846
3 television 0.972
> corpora_best_match('flower',c('television','candy'))
Downloaded model found. Loading downloaded model...
Downloaded model found. Loading downloaded model...
# A tibble: 2 x 2
corpora metric
<chr> <dbl>
1 candy 0.818
2 television 0.972
As part of Packaging guidelines, there is opportunity to clean up the code to improve readability, this includes:
check()
) corpus_viz
function df
and df_30
)I attempted to run check()
, but after 20 minutes my R Studio session aborted and so I was unable to complete the check. Based on how far I did get, no errors were encountered, and reviewing the Git Actions, the tests pass and the coverage is high, so I have no reservations here. It may be worthwhile to look for opportunities to help speed up the check()
.
Hi coRPysprofiling (R)! This is a very neat and great data retrieval and preliminary EDA idea!
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).For packages co-submitting to JOSS
- [ ] The package has an obvious research application according to JOSS's definition
The package contains a
paper.md
matching JOSS's requirements with:
- [ ] A short summary describing the high-level functionality of the software
- [ ] Authors: A list of authors with their affiliations
- [ ] A statement of need clearly stating problems the software is designed to solve and its target audience.
- [ ] References: with DOIs for all those that have one (e.g. papers, datasets, software).
Estimated hours spent reviewing: 1h
General comments:
Hi Team coRPysprofiling!
I really enjoyed reviewing you R package and this is very neat and compelling idea! This package is easy to use, and intriguing to play around with! I tried all functions and they all worked nicely.
On a side note, the Automated tests
worked quite well for an acceptably speed for me and I understood that there are some pretrained models required to download before the tests could run properly, so I am happy and okay with how your unit tests are.
Specific parts:
Considering the target audience (talent acquisition specialists who want to quickly retrieve valuable information from resume texts or compare text from two resumes) who your team and the package intend to help, there are some suggestions I came up with that you might find helpful to know about at least:
corpora_best_match
function, it might be even more straightforward to see if the function could output the variable name in addition to the actual texts associated with the variable, especially in the case of a very long-length text, such as a paragraph from a resume. Below is the example of very long-length output text with no variable name indicating which text belongs to which particular job description/resume.`#> # A tibble: 6 x 2
corpora_best_match
function, it might be less distracting for the users if the function could show no warning/message information in the output, especially when the users want to compare more than 20 different resume sentences (the function would first output more than 20 Downloaded model found. Loading downloaded model...
messages). Below is the example of the warning/messages.`corpora_best_match(mds, job_list, metric = "euclidean")
corpus_viz
, corpora_compare
, and corpora_best_match
, it would be even more benefitical and easy to use if users could directly input a .csv/word/pdf file as resumes are usually in these forms.Overall you have done a phenomenal job! Rachel Xu
Submitting Author: Anita Li (@AnitaLi-0371), Elanor Boyle-Stanley (@eboylestanley), Junghoo Kim (@jkim222383), Ivy Zhang (@ssyayayy) Repository: https://github.com/UBC-MDS/coRPysprofiling-R/tree/v0.3.1 Version submitted: v0.3.1 Editor: Tiffany Timbers(@ttimbers ) Reviewers: TBD
Archive: TBD Version accepted: TBD
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
Who is the target audience and what are scientific applications of this package?
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category?
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
[ ] Do you intend for this package to go on CRAN?
[ ] Do you intend for this package to go on Bioconductor?
[ ] Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
- [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)Code of conduct