UBC-MDS / software-review-2022

0 stars 0 forks source link

Submission group 28: CovidTrackerR #52

Open Davidwang11 opened 2 years ago

Davidwang11 commented 2 years ago

Submitting Author:

Package Name: CovidTrackerR One-Line Description of Package: CovidTrackerR provides basic data cleaning, wrangling and plotting of Covid tracking data in Canada. Repository Link: https://github.com/UBC-MDS/Group28-CovidTracker-R Version submitted:
Editor: TBD
Reviewer 1: Aldo de Almeida Saltao Barros Reviewer 2: Morgan Rosenberg Reviewer 3: Affrin Sultana Reviewer 4: Katia Aristova Archive: TBD
Version accepted: TBD

Package: CovidTrackerR
Title: Tracking covid data in Canada
Version: 0.0.0.9000
Authors@R: 
    person("Cuthbert", "Chow", , "first.last@example.com", role = c("aut", "cre"))
    person("Tianwei", "Wang", , "first.last@example.com", role = c("aut", "cre"))
    person("Siqi", "Tao", , "first.last@example.com", role = c("aut", "cre"))
    person("Jessie", "Wong", , "first.last@example.com", role = c("aut", "cre"))
Description: Provides basic data cleaning, wrangling and plotting of Covid tracking data in Canada.
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
Suggests: 
    testthat (>= 3.0.0)
Config/testthat/edition: 3
Imports: 
    lubridate,
    geojsonio,
    stringr,
    dplyr,
    broom,
    plotly,
    httr,
    mapproj
Depends: 
    tidyverse

Scope

The package is designed for the easy retrieval and analysis of data pertaining to Covid trends in Canada, including information about cases, vaccinations, testing, and mortality. The package serves as a wrapper for the opencovid.ca API, and provides additional helper functions for visualising the data, either as a time series or in the form of a map, and summary information during a time period.

Any people who have basic R knowledge and care about the covid-related information in Canada.

There are several R packages, which have some overlapping functionality as our package, but none which perform all the data acquisition, analysis, and graphing tasks which CovidTracker encompasses. The packages designed for covid data retrieval also do not use the same data source as CovidTracker and do not provide the same level of granularity.

Technical checks

Confirm each of the following by checking the box.

This package:

Publication options

MEE Options - [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)

Code of conduct

aldojasb commented 2 years ago

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

Documentation

The package includes all the following forms of documentation:

Functionality

Estimated hours spent reviewing: 2 hours


Review Comments

  1. The test file is very well designed, my only suggestion here is to put more tests (asserts) for the function getcoviddata.
  2. The functions in R are working pretty well, I would only suggest tidier output for the function calculate_stat_summary. A table output would be great here.
  3. Similar packages session is also good. My only suggestion here is to explain a little bit better the benefits and drawbacks of the other packages and compare how your package is better than those ones.
  4. the Usage and Examples is pretty good. My only suggestion here is to cut off the code part and insert only the code for the function and the outcome, removing the other R's outputs like "Loading required package: tidyverse", etc.
  5. The functions in R are working pretty well, I would only suggest adding a new input for the plot_timeseries in which you can select the period that you want in the plot. e.g from july-2020 to dez-2020.
morganrosenberg50 commented 2 years ago

Package Review

Documentation

The package includes all the following forms of documentation:

Functionality

Estimated hours spent reviewing: 2 hr


Review Comments

There are binary versions available but the source versions are later: binary source needs_compilation units 0.7-2 0.8-0 TRUE sf 1.0-5 1.0-6 TRUE

However, I'm still unable to install these binary versions - this may be a problem with my machine, however, I would advise testing on a MacBook M1 chip machine (if you already have, this is definitely a me problem, and when I figure it out I'll aim to circle back!).

Based on: https://devguide.ropensci.org/reviewtemplate.html

Affrin101 commented 2 years ago

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

Estimated hours spent reviewing: 1.5 hours

Review Comments

katerinkus commented 2 years ago

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

Documentation

The package includes all the following forms of documentation:

Functionality

Estimated hours spent reviewing: 1.5h


Review Comments

This is a helpful and versatile package and I can easily see how it could be further expanded. It could have hospitalization counts and death counts and other info.