Open Davidwang11 opened 2 years ago
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing: 2 hours
Usage and Examples
is pretty good. My only suggestion here is to cut off the code part and insert only the code for the function and the outcome, removing the other R's outputs like "Loading required package: tidyverse", etc.The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing: 2 hr
There are binary versions available but the source versions are later: binary source needs_compilation units 0.7-2 0.8-0 TRUE sf 1.0-5 1.0-6 TRUE
However, I'm still unable to install these binary versions - this may be a problem with my machine, however, I would advise testing on a MacBook M1 chip machine (if you already have, this is definitely a me problem, and when I figure it out I'll aim to circle back!).
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
Briefly describe any working relationship you have (had) with the package authors.
[x] As the reviewer I confirm that there are no conflicts of interest for me to review this work (if you are unsure whether you are in conflict, please speak to your editor before starting your review).
Documentation The package includes all the following forms of documentation:
[x] A statement of need: clearly stating problems the software is designed to solve and its target audience in README
[x] Installation instructions: for the development version of package and any non-standard dependencies in README
[x] Vignette(s): demonstrating major functionality that runs successfully locally
[x] Function Documentation: for all exported functions
[x] Examples: (that run successfully locally) for all exported functions
[x] Community guidelines: including contribution guidelines in the README or CONTRIBUTING, and DESCRIPTION with URL
, Bug Reports
and Maintainer
(which may be autogenerated via Authors@R
).
Functionality
[x] Installation: Installation succeeds as documented.
[x] Functionality: Any functional claims of the software been confirmed.
[ ] Performance: Any performance claims of the software been confirmed.
[x] Automated tests: Unit tests cover essential functions of the package and a reasonable range of inputs and conditions. All tests pass on the local machine.
[x] Packaging guidelines: The package conforms to the rOpenSci packaging guidelines.
Estimated hours spent reviewing: 1.5 hours
date
parameter in the vignette but not in the README. Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing: 1.5h
This is a helpful and versatile package and I can easily see how it could be further expanded. It could have hospitalization counts and death counts and other info.
count
column represented in calculate_stat_summary()
function. I am guessing it is the total number of records. If so, I am not sure if it is useful in this context.plot_timeseries()
function. My first instinct was to use the same format as in the output of get_covid_data()
: 25-09-2020
. However, the package asked me to restructure the date to this format: YYYY-MM-DD. The resulting plot looked difficult to read and it is unclear what year it is for. Perhaps, it may be a better idea to use some other format. I also was not sure what was meant by: trendlines and smoothing options as I only found start and end options.
Submitting Author:
Package Name: CovidTrackerR One-Line Description of Package: CovidTrackerR provides basic data cleaning, wrangling and plotting of Covid tracking data in Canada. Repository Link: https://github.com/UBC-MDS/Group28-CovidTracker-R Version submitted:
Editor: TBD
Reviewer 1: Aldo de Almeida Saltao Barros Reviewer 2: Morgan Rosenberg Reviewer 3: Affrin Sultana Reviewer 4: Katia Aristova Archive: TBD
Version accepted: TBD
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
The package is designed for the easy retrieval and analysis of data pertaining to Covid trends in Canada, including information about cases, vaccinations, testing, and mortality. The package serves as a wrapper for the opencovid.ca API, and provides additional helper functions for visualising the data, either as a time series or in the form of a map, and summary information during a time period.
Any people who have basic R knowledge and care about the covid-related information in Canada.
There are several R packages, which have some overlapping functionality as our package, but none which perform all the data acquisition, analysis, and graphing tasks which CovidTracker encompasses. The packages designed for covid data retrieval also do not use the same data source as CovidTracker and do not provide the same level of granularity.
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Explain reasons for any
pkgcheck
items which your package is unable to pass.Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
[ ] Do you intend for this package to go on CRAN?
[ ] Do you intend for this package to go on Bioconductor?
[ ] Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
- [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)Code of conduct