Open Arushi282 opened 2 years ago
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing: 1.5 hrs
Installation guide was simple and easy to follow. Installation was successful without any difficulties. The example code in README was very helpful for me to check the functionality of your package.
The function codes are well written and well documented. Like the case of python package, addition of more codes for testing would increase the robustness of the package.
The badges in the README are really helpful for others to quickly find out the status of the package and the repo. It is great that the code coverage is higher than 90%.
I am just wondering why JavaScript is being displayed as the mostly used language in your GitHub repo. You can find the languages section in the righthand side of your GitHub repo.
I would be better to clean up the To do lists from the project board. Overall, your package and repo looks great.
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing: 1 hour
I installed the package without any issues and I could follow the example as provided in the README. The functionality of the package looks great. I have mentioned my observations below:
From the code and functionality perspective, I don't think I can suggest any improvements that are required in this package at this stage. Once again, a great job on developing this package.
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing:
I was able to successfully install the package without any issues. In general, the package looks great and is very useful. I only have some minor suggestions to further improve the package:
Overall it is a very awesome package, and great work Group 20!
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
URL
, BugReports
and Maintainer
(which may be autogenerated via Authors@R
).Estimated hours spent reviewing: 1 hour
Great work on this package! I had no issues installing it and running the example provided under the usage section. Please find below some comments that maybe useful for further development:
1) I see that the CONTRIBUTING file is missing from the root directory. It will be useful to have, and link this to the Contributing section in the README.
2) It will be nice to see the rendered page of the package documentation including the vignette linked on the README.
3) The LICENSE.md file does not list the name of the authors explicitly.
4) The fit within the R ecosystem is well explained. However, other packages that carry out text processing can be mentioned as they are also similar to some of the functions included in this package.
5) The worldcloud2
files are currently under the test folder - perhaps it would make more sense for it to reside under the src folder?
All in all this package provides fantastic utility so kudos to all of you!
name: clevercloudr about: Creating meaningful and customized word clouds
Submitting Author Names: Arushi Ahuja @Arushi282, Amelia Tang @aimee0317, Victor Francis @Vikiano, Adrianne Leung @adrianne-l Repository: https://github.com/UBC-MDS/clevercloudr Version submitted: v1.0.1 Submission type: Standard Editors: Arushi Ahuja @Arushi282, Amelia Tang @aimee0317, Victor Francis @Vikiano, Adrianne Leung @adrianne-l Reviewers: Mukund Iyer @miyer26, Hatef Rahmani @hatefr, Arijeet CHATTERJEE @arijc76, John Lee @johnwslee Language: R
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
The package extracts the frequency of words and displays them in a word cloud image that is easy to interpret.
People who need to do basic visualization for Natural Language Processing (NLP).
WordCloud: a word count generator that emphasis more frequently used words from an array of strings and represents them in the form of an image.
What we do differently: (1) Our aim is to improve on the pre-processing of strings before creating a wordcloud in order to make it more user specific and efficient. (2) Word cloud only eliminates limited amount of stopwords, but with our package we are giving users the opportunity to add more stopwords that cater to their analysis. (3) We are focused on removing as many redundant and duplicate words by setting strings to lower case, removing punctuation, lemmatizing and stemming the text.
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Explain reasons for any
pkgcheck
items which your package is unable to pass.Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
[ ] Do you intend for this package to go on CRAN?
[ ] Do you intend for this package to go on Bioconductor?
[ ] Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
- [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)Code of conduct