Feedback on Milestone 2 - Githubissues

UBC-MDS / student_performance

An automated and reproducible analysis of romantic relationship on grades

1 stars 2 forks source link

Feedback on Milestone 2 #21

Open nuranskitchen opened 5 years ago

nuranskitchen commented 5 years ago

@zxzzhangg and @YenanZ, great job on Milestone 2! Here are some remaining issues:

[x] Include instructions on how to run your analysis with make on the main readme
[x] Add links to the specific folders you mention in "Repo structure" section on the readme

Suggestions:

[ ] Go through http://swcarpentry.github.io/make-novice/reference. This would help you make your Make code more practical. For example, you can use automatic variables and avoid some repetition.

YenanZ commented 5 years ago

The changes has been incorporated