search

UBC-MDS / tech_salary_predictor_canada_us

Predict salaries in Canada in the tech industry using StackOverflow data
MIT License
1 stars 4 forks source link

Milestone 1 Review #39

Open mohamad-amin opened 2 years ago

mohamad-amin commented 2 years ago

Here are my feedbacks for Milestone 1:

  1. Draft a Team work contract: Correctness Where is the email to which we would like to report a possible instance of unacceptable behaviour to? Also, typo in the word "behaviour".

  2. Project proposal: reasoning Nice report! The only missing points in my mind are:

    • How are you going to evaluate your model and selected features?
    • Which plots do you plan to use for the visualization section and what would you like to infer from those plots?

  3. Exploratory data analysis in a literate code document: QUALITY Pretty nice! You could also go a bit deeper with your plots and explore different combinations of multiple features. Like people who know HTML and have worked for 5+ years.

khalidcawl commented 2 years ago

Thank you for the valuable feedback Mohamed! We will incorporate these into the current state of the project. Much appreciated.

suuuuperNOVA commented 2 years ago

Hi Mohamad,

Thank you for your valuable feedback. Based on your suggestions, our team has made the following changes:

  1. Teamwork contract was modified with unacceptable behavior examples added. Please check the following link: https://docs.google.com/document/d/15DBToo9IPDK9lSnfAjIwGCgZ5ErsicZvzZNTaLUEuiA/

  2. In terms of model evaluation, we compare $R^2$ of training and test data set to assess if the model is robust. Feature selection, so far, is not investigated, but we hope we could have opportunities to do it to improve our research. Please check commit@6f9be53.
    Plus, the error analysis plot (Fig 8 in the report) is added to help visualize the prediction capability of our model. test_data_result

  3. We added one more EDA plot (Fig 7 in the report) which describes both effects of coding years and languages mastered on salary. Please check commit@e636894. language_codeyears_plot

Hope you could enjoy it. Many thanks.