UBC-STAT / stat545.stat.ubc.ca

Repository that produces the STAT 545 @ UBC website
https://stat545.stat.ubc.ca
Creative Commons Attribution 4.0 International
41 stars 83 forks source link

Milestone2 #54

Closed dy-lin closed 4 years ago

dy-lin commented 4 years ago

Here are the proposed grading and instructions for milestone 2. If this merge request is approved, I will copy this README to the instructor repo as well!

I don't see anyone on Asana assigned to review milestone2, so I'll just add some reviewers!

From the teamwork document: Developing material for the course: TA works independently; but must get the final OK from one other member of the teaching team.

dy-lin commented 4 years ago
  • Milestones 2 and 3 are graded as follows:
    • Troubleshooting is worth 15 points
    • Pull requests are worth 15 points, based on:
    • A good title and description. A good title is self-explanatory, and a good description clearly states what was changed in the pull request and why.
    • Productive discussion. Both students engaged in discussion in the pull request, and made changes to the document accordingly.

Oops, just saw this on the course webpage: https://stat545.stat.ubc.ca/collaborative-about/ Is this something I can modify or should I just change the grading scheme in the milestone2 README.md?

Currently I have a 45 point total for Milestone 2, as there are 24 errors to fix in the troubleshooting document so it would be an awkward point system to scale it down to 15.

I will update the pull request part to add in the criteria of a good title and description and productive discussion, but again, I was planning on having 10 pull requests, each worth 2 points.

vincenzocoia commented 4 years ago

Oh! And I just saw your second comment, @dy-lin . I'll take a look at the troubleshooting document for better context.

vincenzocoia commented 4 years ago

OK, once the number of points issue is sorted out, I approve this pull request :)

dy-lin commented 4 years ago

Ok-- I think we can change it so that it sticks to the original plan of 30 points, adhering to the original 15/15 system.

Troubleshooting: 15 points (0.625 points per error) Pull requests: 15 points (1.5 points per pull request: 0.75 for creating the pull request/proposing a fix; 0.75 for explaining the fix)

I'll implement these into the README and then merge.