search

UBC-STAT / stat545.stat.ubc.ca

Repository that produces the STAT 545 @ UBC website
https://stat545.stat.ubc.ca
Creative Commons Attribution 4.0 International
41 stars 83 forks source link

Assignment 2-B #80

Closed dy-lin closed 3 years ago

dy-lin commented 4 years ago

Hi @vincenzocoia

Here's the first draft of Assignment-2B. While I agree, that it does look very hefty, I anticipate that most students will only be wrapping one function or dataset, so I think it will be manageable.

Please let me know if there are any areas that require clarification for the students. I myself don't remember a whole lot from creating R packages (basically just following along in class for participation last year), and don't recall that much about usethis. I followed fairly closely to your vision, moving some tasks to 'optional' as it seems like it could be too much to do things like covr or pkgdown.

vincenzocoia commented 4 years ago

This looks great. I made a few minor changes, but I think it's well-structured. @sciclic can you take a look as well?

vincenzocoia commented 4 years ago

@dy-lin Can we add a note to this assignment, saying that they will have the opportunity to expand on their R package in Assignment 5-B if they'd like? So, before they do more work than the assignment asks for, they should tag a release, and then work further, so that the extra work can go towards Assignment 5-B

dy-lin commented 4 years ago

@sciclic @vincenzocoia updated with feedback, let me know what you think! In the doc, I decided to just add an EXPLANATIONS.md file in the root of the repository for now, open to suggestions for this.

Also decided to have two tagged releases: 1 in the assignment repository (the README should link to new R package repository), and 1 for the package itself.

Once you two review, I'll change the version number and merge to master