UBC-Thunderbots / Software

Robot Soccer Playing AI
http://www.ubcthunderbots.ca
GNU Lesser General Public License v3.0
53 stars 99 forks source link

Implement FriendlyBallPlacementPlay isApplicable and invariantHolds tests #2252

Closed akhilveeraghanta closed 2 years ago

akhilveeraghanta commented 2 years ago

Description of the task

isApplicable() determines if the play should start running invariantHolds() determines if the play should continue running (isApplicable() was true earlier to start the play)

Currently, the isApplicable() and invariantHolds() functions of the play are untested. We had a lot of bugs because of this at Virtual Robocup. We need to implement a test for each.

Take a look at an example of how to do this for HaltPlay, the setup of the Play, World, GameState and ASSERT_TRUE/FALSE will be similar for your test: https://github.com/UBC-Thunderbots/Software/pull/2251/files

NOTE:

Acceptance criteria

Blocked By

N/A

jonathanlew commented 2 years ago

fixed by #2276