Refactor duplicate kick power calculation - Githubissues

UBC-Thunderbots / Software

Robot Soccer Playing AI

http://www.ubcthunderbots.ca

GNU Lesser General Public License v3.0

53 stars 110 forks source link

Refactor duplicate kick power calculation #3193

Open Bvasilchikov opened 4 months ago

Bvasilchikov commented 4 months ago

Description of the task

The same exponential formula for calculating pulse width using kick coefficient and constant is copied and pasted twice in power_frame_msg.hpp.

https://github.com/UBC-Thunderbots/Software/blob/7083fe53b19dfb3987880782259a6eeaf6536e9e/src/proto/message_translation/power_frame_msg.hpp#L141-L144

https://github.com/UBC-Thunderbots/Software/blob/7083fe53b19dfb3987880782259a6eeaf6536e9e/src/proto/message_translation/power_frame_msg.hpp#L161-L165

Acceptance criteria

[ ] Move calculation to a separate function so that we can reuse it

Blocked By