Visualizing the Attacker Tactic internals: The pass that is being considered (faint red line) or we're comitted to taking it (blue line), A shot we're planning on taking and its open angle on net (red line), and a target position for chipping if we're planning to chip the ball. (side note: I have decided to keep the existing Passing Layer for now, which visualizes a similar faint line for the set of best passes. In it's current form it's not very useful and often ignored. I think long term we should look into ways of improving it or removing it).
Adding controls for the simulation speed. The new controls are also binded with keyboard shortcuts for easy change of speed (Ctrl+Up Arrow for increasing simulation speed and Ctrl+Down Arrow for decreasing simulation speed). This is specially helpful for moments in the gameplay where you want to pay attention to the actions taken by AI, or moments where you want to increase the simulation speed in hopes of reaching some desired state.
Updated debug shapes layer to take in a unique ID for the shape being visualized. This will now allow you to visualize shapes without any text, or visualize multiple shapes with the same text (i.e. the text shown on screen does not have to be unique anymore).
Added new graphic item over the robot's dribbler area to visualize if auto kick or auto chip is enabled
Testing Done
Thunderscope runs without any errors and new changes appear to be working :)
Resolved Issues
An extension to #3144
Resolves #3135
Resolves #3224
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
[ ] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
[ ] Remove all commented out code
[ ] Remove extra print statements: for example, those just used for testing
[ ] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
Description
Various visualization improvements including:
Ctrl+Up Arrow
for increasing simulation speed andCtrl+Down Arrow
for decreasing simulation speed). This is specially helpful for moments in the gameplay where you want to pay attention to the actions taken by AI, or moments where you want to increase the simulation speed in hopes of reaching some desired state.Testing Done
Thunderscope runs without any errors and new changes appear to be working :)
Resolved Issues
An extension to #3144 Resolves #3135 Resolves #3224
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO
(or similar) statements should either be completed or associated with a github issue