For the past few months I have been noticing that often Thunderscope takes noticeably longer to launch compared to before. After using git bisect (pretty useful tool for tracking down regressions that I just learned about) I was able to narrow down the problem to #2788 where the sync_simulation function was refactored that added up to 6 seconds to the launch time on my PC.
There were two other smaller changes that I also included in this PR. One was removing an extra window.show() call for Thunderscope, and another being how large the widgets are at launch time of Thunderscope.
Testing Done
Measured the time between self.window.showMaximized() call and pyqtgraph.exec() across multiple commits to verify the issue, then I verified that the time reduced from 6-8 seconds to 0.3-1 second.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
[ ] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
[ ] Remove all commented out code
[ ] Remove extra print statements: for example, those just used for testing
[ ] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
Description
For the past few months I have been noticing that often Thunderscope takes noticeably longer to launch compared to before. After using
git bisect
(pretty useful tool for tracking down regressions that I just learned about) I was able to narrow down the problem to #2788 where thesync_simulation
function was refactored that added up to 6 seconds to the launch time on my PC.There were two other smaller changes that I also included in this PR. One was removing an extra
window.show()
call for Thunderscope, and another being how large the widgets are at launch time of Thunderscope.Testing Done
Measured the time between
self.window.showMaximized()
call andpyqtgraph.exec()
across multiple commits to verify the issue, then I verified that the time reduced from 6-8 seconds to 0.3-1 second.Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO
(or similar) statements should either be completed or associated with a github issue