Please fill out the following before requesting review on this PR
Description
Simple refactoring task for EnemyFreeKickPlayFSM and DefensePlayFSM classes into new DefensePlayBase base class.
Testing Done
Passes all pytests & builds. Thunderscope working.
Resolved Issues
Resolves #3212
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
[x] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
[x] Remove all commented out code
[x] Remove extra print statements: for example, those just used for testing
[x] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
Please fill out the following before requesting review on this PR
Description
Simple refactoring task for
EnemyFreeKickPlayFSM
andDefensePlayFSM
classes into newDefensePlayBase
base class.Testing Done
Passes all pytests & builds. Thunderscope working.
Resolved Issues
Resolves #3212
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO
(or similar) statements should either be completed or associated with a github issueBlocked by #3179