Some minor fixes after field testing a few days ago. One includes ball placement causing a segfault when num_tactics == 0 due to an underflow issue with num_tactic - 1. The other is related to logs being spammed from the robot when we disable-enable the estop.
Testing Done
Changes should not affect any logic.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
[ ] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
[ ] Remove all commented out code
[ ] Remove extra print statements: for example, those just used for testing
[ ] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
Description
Some minor fixes after field testing a few days ago. One includes ball placement causing a segfault when
num_tactics == 0due to an underflow issue withnum_tactic - 1. The other is related to logs being spammed from the robot when we disable-enable the estop.Testing Done
Changes should not affect any logic.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue