UBC-Thunderbots / Software

Robot Soccer Playing AI
http://www.ubcthunderbots.ca
GNU Lesser General Public License v3.0
53 stars 110 forks source link

[Gameplay] PassDefenders Should Attempt to Steal Intercepted Balls #3240

Closed Andrewyx closed 2 months ago

Andrewyx commented 3 months ago

Please fill out the following before requesting review on this PR

Description

Provides similar features as #3230 to pass defenders, where they can take possession of the ball on a successful intercept. Consolidates Crease and Pass defenders with new base class containing shared functions.

Testing Done

Added FSM tests and additional pytest validations.

Resolved Issues

Resolves #3217 Partially Blocked by #3230

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

Mr-Anyone commented 3 months ago

Honestly, looks about right. I think you are basically there!

Maybe add a test of some sort since this is a FSM?