UBC-Thunderbots / Software

Robot Soccer Playing AI

http://www.ubcthunderbots.ca

GNU Lesser General Public License v3.0

53 stars 110 forks source link

GEOM: Make a Spline(std::vector<Points> points, unsigned int order) constructor #983

Closed jonathanlew closed 4 years ago

jonathanlew commented 5 years ago

Description of the task

Spline(std::vector points, unsigned int order) constructor will take the points and interpolate with order degree polynomials with C(order - 1) continuity

Acceptance criteria

[ ] Make a Spline(std::vector points, unsigned int order) constructor
[ ] Replace calls to Spline(std::vector points) with Spline(points, 1)
[ ] Test it

Blocked By

942

MathewMacDougall commented 4 years ago

Evan asked for a Spline.length() function to get the length of the spline

garethellis0 commented 4 years ago

Just as a note, this likely won't get done, we already have linear splines (essentially connected line segments) and I'm going to implement a CubicBezierSpline, but a generic spline class actually gets quite tricky in terms of specifying constraints in a user-friendly way.

akhilveeraghanta commented 4 years ago

@garethellis0 can we close this ticket now, since we have the Bezier curve implementation?

garethellis0 commented 4 years ago

Yes, in retrospect this was overly ambitiously general.