UBCSailbot / custom_interfaces

UBC Sailbot's custom interfaces ROS package
MIT License
0 stars 0 forks source link

Add LocalPath topic for website to visualize #15

Closed jamenkaye closed 1 year ago

jamenkaye commented 1 year ago

Description

Local Pathfinding would like to visualize paths on the website. This provides a ROS topic to communicate the path to the website.

Verification

Things I'd like to confirm:

Also, should we rename the GlobalPath type to just Path or WaypointList or something, since the same type is used for Local and Global paths?

jamenkaye commented 1 year ago

Patrick pointed out that Pathfinding may want to communicate other data to the website to be visualized. This data can now be added to the LPathData type. As I'm still unsure exactly what form the other data will take, I haven't added it yet, so currently LPathData just includes a Path.

I'm not sure how to fix the failing test? I thought the colcon test was for tests in the test folder, but this repo doesn't seem to have one.

patrick-5546 commented 1 year ago

I'm not sure how to fix the failing test?

It can't build, you can verify this by running the build package for custom_interfaces task locally.

You have to add your new msg here: https://github.com/UBCSailbot/custom_interfaces/blob/d3c8af1e4c0fe6d7848031569187f81330e49785/CMakeLists.txt#L16-L35