search

UBCSailbot / raye-global-pathfinding

UBC Sailbot's Global Pathfinding Repository: A* pathfinding that creates sailing paths with minimized length and desirable wind speeds throughout.
MIT License
5 stars 1 forks source link

Fix cpplint errors #13

Closed Alexmac22347 closed 4 years ago

Alexmac22347 commented 4 years ago

Low priority Errors are: ===== Running CPP lint ===== ./scripts/../src/grib/gribParse.h:2: #ifndef header guard has wrong style, please use: GRIB_GRIBPARSEH [build/header_guard] [5] ./scripts/../src/grib/gribParse.h:30: #endif line should be "#endif // GRIB_GRIBPARSEH" [build/header_guard] [5] ./scripts/../src/grib/gribParse.h:8: "iostream" already included at ./scripts/../src/grib/gribParse.h:7 [build/include] [4] ./scripts/../src/grib/gribParse.h:13: public: should be indented +1 space inside class FileParse [whitespace/indent] [3] ./scripts/../src/grib/gribParse.h:14: Use int16/int64/etc, rather than the C type long [runtime/int] [4] ./scripts/../src/grib/gribParse.h:20: Single-parameter constructors should be marked explicit. [runtime/explicit] [5] ./scripts/../src/grib/gribParse.h:22: private: should be indented +1 space inside class FileParse [whitespace/indent] [3] ./scripts/../src/grib/gribParse.h:27: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] ./scripts/../src/grib/gribParse.h:30: At least two spaces is best between code and comments [whitespace/comments] [2] ./scripts/../src/grib/gribParse.h:30: Should have a space between // and comment [whitespace/comments] [4] ./scripts/../src/grib/windFileParse.h:0: No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5] ./scripts/../src/grib/windFileParse.h:1: #ifndef header guard has wrong style, please use: GRIB_WINDFILEPARSEH [build/header_guard] [5] ./scripts/../src/grib/windFileParse.h:38: #endif line should be "#endif // GRIB_WINDFILEPARSEH" [build/header_guard] [5] ./scripts/../src/grib/windFileParse.h:6: "iostream" already included at ./scripts/../src/grib/windFileParse.h:5 [build/include] [4] ./scripts/../src/grib/windFileParse.h:14: public: should be indented +1 space inside class WindFileParse [whitespace/indent] [3] ./scripts/../src/grib/windFileParse.h:15: Use int16/int64/etc, rather than the C type long [runtime/int] [4] ./scripts/../src/grib/windFileParse.h:22: Single-parameter constructors should be marked explicit. [runtime/explicit] [5] ./scripts/../src/grib/windFileParse.h:23: Missing space after , [whitespace/comma] [3] ./scripts/../src/grib/windFileParse.h:23: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration. [build/storage_class] [5] ./scripts/../src/grib/windFileParse.h:24: Missing space after , [whitespace/comma] [3] ./scripts/../src/grib/windFileParse.h:24: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration. [build/storage_class] [5] ./scripts/../src/grib/windFileParse.h:26: private: should be indented +1 space inside class WindFileParse [whitespace/indent] [3] ./scripts/../src/grib/windFileParse.h:34: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] ./scripts/../src/grib/windFileParse.h:38: At least two spaces is best between code and comments [whitespace/comments] [2] ./scripts/../src/grib/windFileParse.h:38: Should have a space between // and comment [whitespace/comments] [4] ./scripts/../src/grib/windFileParse.cpp:6: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5] ./scripts/../src/grib/windFileParse.cpp:23: Missing space after , [whitespace/comma] [3] ./scripts/../src/grib/windFileParse.cpp:89: You don't need a ; after a } [readability/braces] [4] ./scripts/../src/grib/windFileParse.cpp:42: Mismatching spaces inside () in while [whitespace/parens] [5] ./scripts/../src/grib/windFileParse.cpp:42: Missing space before { [whitespace/braces] [5] ./scripts/../src/grib/windFileParse.cpp:43: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] ./scripts/../src/grib/windFileParse.cpp:47: Missing space before ( in if( [whitespace/parens] [5] ./scripts/../src/grib/windFileParse.cpp:50: Extra space before ( in function call [whitespace/parens] [4] ./scripts/../src/grib/windFileParse.cpp:59: Missing space before ( in if( [whitespace/parens] [5] ./scripts/../src/grib/windFileParse.cpp:61: Extra space before ( in function call [whitespace/parens] [4] ./scripts/../src/grib/windFileParse.cpp:64: Extra space before ( in function call [whitespace/parens] [4] ./scripts/../src/grib/windFileParse.cpp:71: Should have a space between // and comment [whitespace/comments] [4] ./scripts/../src/grib/windFileParse.cpp:75: Should have a space between // and comment [whitespace/comments] [4] ./scripts/../src/grib/windFileParse.cpp:77: Missing space before ( in if( [whitespace/parens] [5] ./scripts/../src/grib/windFileParse.cpp:82: Missing space after , [whitespace/comma] [3] ./scripts/../src/grib/windFileParse.cpp:83: Missing space after , [whitespace/comma] [3] ./scripts/../src/grib/windFileParse.cpp:4: grib/windFileParse.cpp should include its header file grib/windFileParse.h [build/include] [5] ./scripts/../src/grib/gribParse.cpp:4: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5] ./scripts/../src/grib/gribParse.cpp:39: Missing space before ( in if( [whitespace/parens] [5] ./scripts/../src/grib/gribParse.cpp:2: grib/gribParse.cpp should include its header file grib/gribParse.h [build/include] [5] ./scripts/../src/grib/gribParse.cpp:50: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Category 'build/namespaces' errors found: 2 Category 'build/storage_class' errors found: 2 Category 'whitespace/braces' errors found: 1 Category 'build/header_guard' errors found: 4 Category 'whitespace/blank_line' errors found: 3 Category 'runtime/int' errors found: 2 Category 'whitespace/comma' errors found: 5 Category 'build/include' errors found: 4 Category 'readability/braces' errors found: 1 Category 'whitespace/parens' errors found: 8 Category 'whitespace/ending_newline' errors found: 1 Category 'whitespace/comments' errors found: 6 Category 'whitespace/indent' errors found: 4 Category 'legal/copyright' errors found: 1 Category 'runtime/explicit' errors found: 2 Total errors found: 46 ./scripts/../test/basic_tests/grib/WindFileParseTest.h:3: #ifndef header guard has wrong style, please use: GRIB_WINDFILEPARSETESTH [build/header_guard] [5] ./scripts/../test/basic_tests/grib/WindFileParseTest.h:13: #endif line should be "#endif // GRIB_WINDFILEPARSETESTH" [build/header_guard] [5] ./scripts/../test/basic_tests/grib/WindFileParseTest.h:9: protected: should be indented +1 space inside class WindGribParseTest [whitespace/indent] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.h:13: At least two spaces is best between code and comments [whitespace/comments] [2] ./scripts/../test/basic_tests/grib/WindFileParseTest.h:13: Should have a space between // and comment [whitespace/comments] [4] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:5: Found C++ system header after other header. Should be: WindFileParseTest.h, c system, c++ system, other. [build/include_order] [4] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:6: Found C++ system header after other header. Should be: WindFileParseTest.h, c system, c++ system, other. [build/include_order] [4] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:12: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:17: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:18: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:20: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:33: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:37: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:38: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:40: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:50: Missing space after , [whitespace/comma] [3] ./scripts/../test/basic_tests/grib/WindFileParseTest.cpp:51: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Category 'whitespace/comments' errors found: 2 Category 'build/header_guard' errors found: 2 Category 'whitespace/comma' errors found: 9 Category 'whitespace/ending_newline' errors found: 1 Category 'build/include_order' errors found: 2 Category 'whitespace/indent' errors found: 1 Total errors found: 17 ===== CPP lint Failed =====