Migrate Package Specific Dependencies from Image to package.xml

SPDonaghy commented 6 months ago

Description

Partially Resolves #242
Some Python dependencies needed for the local pathfinding ROS package were moved from base-dev.Dockerfile to package.xml in the local_pathfinding repository

Verification

After removing some dependencies from base-dev.Dockerfile, I ran the build images workflow and set the new image tag in the main Dockerfile.
I then rebuilt the container and verified that the pip3 dependencies in base-dev.Dockerfile were installed in the workspace but the dependencies that were moved to package.xml were not.
Next, I ran the setup task and then verified the remaining dependencies were installed.

Resources

This PR only dealt with local_pathfinding dependencies hence only partially resolving the mentioned Sailbot Workspace issue.
Here is the related local_pathfinding PR

To Do

[x] [Patrick] Cleanup dockerfile
[x] [Sean] revert local pathfinding branch to main once its PR is merged
[ ] Migrate NET package dependencies to package.xml
- [ ] "install base apt dependencies" section
- [ ] "install some clang tools and googletest for network systems" section

SPDonaghy commented 6 months ago

Colcon test failed because pyproj is not installed when the tests run. Maybe if we also specify pyproj as a test dependency in package.xml then it will work.

patrick-5546 commented 6 months ago

Setup is run in the tests run: https://github.com/UBCSailbot/sailbot_workspace/blob/b602a2023b7d0c83c96026ba50fb457be09f6c1f/.github/actions/test/run.sh#L5

I think it is failing because it is pulling the main branch of local pathfinding. You can test out your branch by changing this line: https://github.com/UBCSailbot/sailbot_workspace/blob/b602a2023b7d0c83c96026ba50fb457be09f6c1f/src/polaris.repos#L48

SPDonaghy commented 6 months ago

I think it is failing because it is pulling the main branch of local pathfinding. You can test out your branch by changing this line:

Hm I tried this but its still not working.

This is what you meant right?

Running the setup task manually and then the test task works. But just running test does not. It also doesn't complain if I put a wrong branch name in polaris.repos either.

patrick-5546 commented 6 months ago

Hm I tried this but its still not working.

It timed out, which is a known bug: #231

After rerunning it passes

SPDonaghy commented 6 months ago

Actually let's keep this open for now and use it to clean up our dependencies across the software team. I'll add a to do list to this PR

Sounds good, and I'll make separate PRs in each repo to update the package.xml files one by one.

patrick-5546 commented 6 months ago

I'll make separate PRs in each repo to update the package.xml files one by one

As far as I can tell what's left is syncing with NET/diagnostics about what dependencies can be migrated to their repo

SPDonaghy commented 6 months ago

After rerunning it passes

So on this branch, when you rebuild and then run the test task, it doesn't error out for you? I'm getting module not found for scipy from controller and pyproj from local_path

UBCSailbot / sailbot_workspace