search

UBCSailbot / sailbot_workspace

UBC Sailbot's monorepo
https://ubcsailbot.github.io/sailbot_workspace/main/
Apache License 2.0
4 stars 1 forks source link

[WEB] PR #102 Rearrange Charts #282

Closed jahn18 closed 5 months ago

jahn18 commented 5 months ago

Description

Verification

Resources

jahn18 commented 5 months ago

Thanks @fyang151!

@JordanChen123 do you mind doing a pass and taking a look at this?

JordanChen123 commented 5 months ago

Great work! The overall code looks good to me.

There is a slight issue with the state of the graphs after refreshing the page. As an example, if you move the speed graph to the very bottom, and then refresh the page, the state of the Drag and Drop menu stays the same as it was before refreshing the page, but the graphs go back to where they were when the page was loaded up initially.

fyang151 commented 5 months ago

Great work! The overall code looks good to me.

There is a slight issue with the state of the graphs after refreshing the page. As an example, if you move the speed graph to the very bottom, and then refresh the page, the state of the Drag and Drop menu stays the same as it was before refreshing the page, but the graphs go back to where they were when the page was loaded up initially.

oh oops ill look at it rn and try to get it done by tn meeting