UBCSailbot / sailbot_workspace

UBC Sailbot's monorepo
https://ubcsailbot.github.io/sailbot_workspace/main/
Apache License 2.0
5 stars 1 forks source link

Unit tests start 2 http servers on the same port #363

Closed patrick-5546 closed 5 months ago

patrick-5546 commented 5 months ago

Description

A recent NET PR causes the test task to fail: both NET and PATH unit tests start http servers on port 8081

Expected Behavior

Test task should pass

Actual Behavior

On my machine the local pathfinding unit tests run after net, and I get this error: image

Steps to Reproduce

  1. Run the test task

Relevant Code

Potential Solutions

@hhenry01 any ideas? Is the NET global path endpoint working yet? Or should one of the servers run on a different port

hhenry01 commented 5 months ago

I'm assuming this happens because both the NET and PATH unit tests are ran in parallel. We would either need to run the servers on different ports for unit testing only or run the NET and PATH tests sequentially.

patrick-5546 commented 5 months ago

What's the net server for? Is it supposed to mimic the webhook server as well which will run on 8081?

hhenry01 commented 5 months ago

Yes. Virtual Iridium needs an active server or else it will crash.

patrick-5546 commented 5 months ago

@SPDonaghy we should use a different port then until it's implemented on the net side

SPDonaghy commented 5 months ago

@SPDonaghy we should use a different port then until it's implemented on the net side

Sounds good, I can make that change tomorrow