UBCSailbot / sailbot_workspace

UBC Sailbot's monorepo
https://ubcsailbot.github.io/sailbot_workspace/main/
Apache License 2.0
4 stars 1 forks source link

Resolved Markdown Link Check Failure by Accepting 403 Response as a Live Link #419

Closed SPDonaghy closed 1 month ago

SPDonaghy commented 1 month ago

Description

The docs.yml workflow is failing because the following link returns a 403 Forbidden repsonse when the link checker requests the website.

https://www.toptal.com/robotics/introduction-to-robot-operating-system

A 403 response means the server understands the request but refuses to fulfill it. The link works fine with a browser, so the maintainers of Toptal likely are blocking any user agents that are not web browsers.

Ie. this command returns 403 wget https://www.toptal.com/robotics/introduction-to-robot-operating-system and this command returns 200 wget --user-agent="Chrome/58.0.3029.110" https://www.toptal.com/robotics/introduction-to-robot-o perating-system

We're not going to spoof user agents, especially not just to check if a link is live. Therefore I suggest we treat links that get 403 responses as live.

Verification