search

UBICenter / local-child-allowance

Local effects of child allowances
MIT License
2 stars 4 forks source link

Add initial poverty reduction script and ACS data #6

Closed ben-boehlert closed 3 years ago

pep8speaks commented 3 years ago

Hello @ben-boehlert! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 24:80: E501 line too long (81 > 79 characters) Line 41:80: E501 line too long (81 > 79 characters) Line 44:80: E501 line too long (88 > 79 characters) Line 57:80: E501 line too long (86 > 79 characters) Line 58:80: E501 line too long (88 > 79 characters) Line 69:80: E501 line too long (80 > 79 characters) Line 75:80: E501 line too long (87 > 79 characters) Line 81:80: E501 line too long (87 > 79 characters) Line 88:1: E402 module level import not at top of file Line 95:1: E266 too many leading '#' for block comment Line 98:80: E501 line too long (86 > 79 characters) Line 122:62: E231 missing whitespace after ',' Line 132:80: E501 line too long (86 > 79 characters) Line 145:80: E501 line too long (81 > 79 characters) Line 165:80: E501 line too long (85 > 79 characters) Line 171:80: E501 line too long (84 > 79 characters)

Comment last updated at 2021-05-26 16:43:52 UTC
MaxGhenis commented 3 years ago

@ben-boehlert I added my commit to this PR, you should see it locally if you run a git pull from command line in your directory representing the repo

MaxGhenis commented 3 years ago

Per our meeting, @ben-boehlert to:

MaxGhenis commented 3 years ago

Please adapt the script to use the new PUMA-legislative district mapping produced in #15.

MaxGhenis commented 3 years ago

Is this PR still producing the maps you added to the ubicenter.org PR? If so, a few suggestions we can incorporate to the post: