UBICenter / polls

Polls on UBI
https://docs.google.com/spreadsheets/d/1ulqohI6YLYFsz3wm8f5j6BS_JVelu2Ea8SXXa-wwkhQ
MIT License
1 stars 3 forks source link

Launch #83

Closed fedderw closed 3 years ago

fedderw commented 3 years ago

fixes #64 via Katerina's spreadsheet changes, although open question as to whether or not we're satisfied with how all of it looks/where to use it

fedderw commented 3 years ago

EDIT: I might put this in a separate PR, since the rest of these changes can probably be merged now

Re: both #67 (and #64)

New: image Old: image

Relevant questions, lmk what you think @MaxGhenis @kvanalebeek:

MaxGhenis commented 3 years ago

Looks great! I'm not attached to sample size in the bubble chart, but could it be added to the small note in the bottom left of the bar chart? e.g. instead of Country surveyed: USA it could be 1,204 US respondents (at some point we could add specificity around voters, likely voters, adults, etc.).

fedderw commented 3 years ago

Looks great! I'm not attached to sample size in the bubble chart, but could it be added to the small note in the bottom left of the bar chart? e.g. instead of Country surveyed: USA it could be 1,204 US respondents (at some point we could add specificity around voters, likely voters, adults, etc.).

Ok cool. Gonna merge this then since these are all small changes otherwise.

fedderw commented 3 years ago

fixes #64, #69

MaxGhenis commented 3 years ago

Anything needed on my end to deploy the changes?

fedderw commented 3 years ago

Anything needed on my end to deploy the changes?

I got an error with dash_html_components on build 19, so I added that to the environment but got a conda channel error on that in build 20. I'm gonna sign off for the evening, but if you know what's up with that, let me know