search

UBICenter / uk

Simulations of UBI in the UK
MIT License
3 stars 6 forks source link

Update analysis notebook #28

Closed nikhilwoodruff closed 3 years ago

nikhilwoodruff commented 3 years ago

Updated analysis notebook with hopefully final results. Probably needs to be merged after #27 .

MaxGhenis commented 3 years ago

Could you add jb/_build to .gitignore and remove those files from the PR?

pep8speaks commented 3 years ago

Hello @nikhilwoodruff! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:3: E227 missing whitespace around bitwise or shift operator Line 1:7: E225 missing whitespace around operator Line 2:1: E402 module level import not at top of file Line 3:1: E402 module level import not at top of file Line 4:1: E402 module level import not at top of file Line 5:1: E402 module level import not at top of file Line 6:1: E402 module level import not at top of file Line 149:1: E305 expected 2 blank lines after class or function definition, found 0 Line 149:3: E225 missing whitespace around operator Line 149:5: E225 missing whitespace around operator Line 149:7: E225 missing whitespace around operator Line 150:1: E402 module level import not at top of file Line 151:1: E402 module level import not at top of file Line 152:1: E402 module level import not at top of file Line 153:1: E402 module level import not at top of file Line 154:1: E402 module level import not at top of file Line 297:1: E305 expected 2 blank lines after class or function definition, found 0 Line 297:7: E225 missing whitespace around operator

MaxGhenis commented 3 years ago

Actually forgot this is pre-built, given that, do we actually need the _build files?

MaxGhenis commented 3 years ago

Also could you flip the spectrum chart so the positive is on the left? This aligns with the original it was adapted from and I think highlights the benefits of the policy more. image

Could also be nice to somehow pull out specific numbers from it, e.g. x% benefit by 5% or more (or even just x% benefit). But not sure how that'd work, maybe it belongs in a table instead.

nikhilwoodruff commented 3 years ago

Actually forgot this is pre-built, given that, do we actually need the _build files?

I don't think we do, the Jupyter-Book is not actually pre-build, rather the notebooks are pre-executed.